arkworks-rs / curves

Implementations of popular elliptic curves
https://www.arkworks.rs
Apache License 2.0
303 stars 103 forks source link

Add supplementary small group bases for some common fields #137

Closed weikengchen closed 1 year ago

weikengchen commented 1 year ago

Description

This is related to https://github.com/arkworks-rs/algebra/pull/547.

The idea is that for some TurboPlonk implementations, we use the small base not just when we run out of 2-arity, but we use it when constructing the larger domain (e.g., 6x larger). It is preferred to use 6x (by using a 3) rather than 8x.

This is used in the Noah library as a performance improvement.


Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

N/A:

weikengchen commented 1 year ago

Should we add a CHANGELOG entry for this?

weikengchen commented 1 year ago

Depends on https://github.com/arkworks-rs/algebra/pull/547.

weikengchen commented 1 year ago

Needs to debug and fix the one related to secp256k1.

weikengchen commented 1 year ago

Depends on https://github.com/arkworks-rs/algebra/pull/550

weikengchen commented 1 year ago

I think it is ready to merge. I will appreciate a cut of the alpha version. Is the next cut already scheduled? (I dare not to cut a release since the last time I did that was two years ago I think)