Adding `AdditiveGroup` and `PrimeGroup` - Githubissues

arkworks-rs / curves

Implementations of popular elliptic curves

https://www.arkworks.rs

Apache License 2.0

303 stars 103 forks source link

Adding `AdditiveGroup` and `PrimeGroup` #159

Closed autquis closed 1 year ago

autquis commented 1 year ago

See arkworks-rs/algebra#577.

I changed Cargo.toml to avoid redoing what arkworks-rs/r1cs-std#122 has done.

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

[ ] Targeted PR against correct branch (master)
[ ] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[ ] Wrote unit tests
[ ] Updated relevant documentation in the code
[ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer

mmagician commented 1 year ago

I would prefer we first merge the r1cs-std PR to not have master here depend on any forks.

mmaker commented 1 year ago

r1cs-std's PR has been merged!

weikengchen commented 1 year ago

Let me update this PR to see if we can get it ready...

drskalman commented 1 year ago

@weikengchen: we also need this https://github.com/arkworks-rs/r1cs-std/pull/122, right? bandersnatch tests are failing to compile due to that.

mmaker commented 1 year ago

any news on this?

mmaker commented 1 year ago

ping. this is causing problems for the folks at https://github.com/zkCollective/ and I need it for a presentation at DEF CON.