Non-canonical infinity point & bad flags in BLS12-381 serialization should fail

mmagician commented 1 year ago

Description

Follow-up to https://github.com/arkworks-rs/curves/pull/157, the original is stale.

Thanks @ArnaudBrousseau for providing a test for bad flags (lmk if you'd like me to add you as co-author on the commit here)

closes: #157

Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

[x] Targeted PR against correct branch (master)
[x] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[x] Wrote unit tests
[x] Updated relevant documentation in the code
[ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[x] Re-reviewed Files changed in the Github PR explorer

Pratyush commented 1 year ago

Thanks for the great PR @mmagician! Could you add a CHANGELOG entry as this is an important fix? Thanks!

mmagician commented 1 year ago

@Pratyush It's actually a breaking change no?

Pratyush commented 1 year ago

In Rust breaking changes are only when the API changes, not necessarily behaviour

mmagician commented 1 year ago

@Pratyush Thanks, I moved it to Bugfixes.

arkworks-rs / curves

Non-canonical infinity point & bad flags in BLS12-381 serialization should fail #176

Description