arkworks-rs / groth16

A Rust implementation of the Groth16 zkSNARK
https://www.arkworks.rs
Apache License 2.0
242 stars 97 forks source link

Update Groth16 to the latest ark-algebra #39

Closed weikengchen closed 1 year ago

weikengchen commented 2 years ago

Description

This is a draft PR that is incomplete. After https://github.com/arkworks-rs/snark/pull/362 is merged, we can continue on this draft PR to fix the remaining ones.


Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

N/A:

Pratyush commented 1 year ago

What's the diff between this and #40?

weikengchen commented 1 year ago

Good question. I think the easiest way is for me to revert 40 and change its target

weikengchen commented 1 year ago

Nay it is easier to merge it here. Let me do a final pass.