arkworks-rs / groth16

A Rust implementation of the Groth16 zkSNARK
https://www.arkworks.rs
Apache License 2.0
242 stars 97 forks source link

Remove `ark-relations/std` dependency #63

Open mzabaluev opened 1 month ago

mzabaluev commented 1 month ago

Description

The std feature in ark-relations pulls in the hefty, and currently outdated (https://github.com/arkworks-rs/snark/issues/356), dependency on tracing-subscriber. Luckily, this dependency does not seem to be needed here at all.


Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

weikengchen commented 1 month ago

Can you confirm if this change would work? The reason is that ark-crypto-primitives/std also will invoke ark-relations/std.

mzabaluev commented 1 month ago

Can you confirm if this change would work? The reason is that ark-crypto-primitives/std also will invoke ark-relations/std.

I have submitted https://github.com/arkworks-rs/crypto-primitives/pull/146 to remove that dependency as well. However, it is still pulled in by r1cs-std/std, so I have submitted https://github.com/arkworks-rs/r1cs-std/pull/147.