[Q] why not implement UniversalSetupSNARK for Marlin

arkworks-rs / marlin

A Rust library for the Marlin preprocessing zkSNARK

Apache License 2.0

315 stars 85 forks source link

[Q] why not implement UniversalSetupSNARK for Marlin #72

Closed alxiong closed 3 years ago

alxiong commented 3 years ago

May I ask why ark_snark::UniversalSetupSNARK trait is not implemented for struct Marlin when all of its functions (including those of a trait SNARK) are being implemented with the same func signature?

weikengchen commented 3 years ago

Good points. We have the implementations of it in a work-in-progress branch (https://github.com/arkworks-rs/marlin/blob/constraints/src/constraints/snark.rs), but it has not been merged into the master branch yet.

alxiong commented 3 years ago

Awesome! good to know that it's not because of some wacky edge cases or special consideration, and that the trait indeed provides reasonable fidelity to actual/concrete universal snark instantiation. 👍

Thanks!