Closed TakodaS closed 1 year ago
I think we shouldn't do this, as the labels exist purely at runtime; the versions absorbed into the sponge should be the unlabelled commitments.
I think we shouldn't do this, as the labels exist purely at runtime; the versions absorbed into the sponge should be the unlabelled commitments.
Having delved further into the marlin repo, I agree. Closing.
Description
Added CanonicalSerialize/Deserialize traits to the LabeledCommitment struct.
When poly-commit was updated to v0.4.0, the trait
ToBytes
was removed from LabeledCommit but the Serialization traits were not added.Blocks arkworks-rs/marlin/pull/94 as LabeledCommit structs need to be absorbed by the sponge function to add entropy.
Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the Github PR explorer