arkworks-rs / poly-commit

A Rust library for polynomial commitments
Apache License 2.0
309 stars 123 forks source link

Replace `Group` with `AdditiveGroup` for KZG, Marlin, and Sonic #126

Closed autquis closed 9 months ago

autquis commented 9 months ago

After the recent changes to ark-ec, there is no Group trait anymore. Currently, if we patch the dependency on crypto-primitive, everything is alright. However, if we use the feature merkle_tree from crypto-primitive, then poly-commit does not build. In this PR, I patched dependencies with their git version and changed Group to AdditiveGroup.


Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

mmagician commented 9 months ago

I believe you need to also patch r1cs-std, which is used in benches.