Rename nonnative to emulated, as in `r1cs-std`

autquis commented 6 months ago

Just a refactor according to the last changes in r1cs-std

Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

[ ] Targeted PR against correct branch (master)
[ ] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[ ] Wrote unit tests
[ ] Updated relevant documentation in the code
[ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer

autquis commented 6 months ago

The CI fails. It is probably due to the instability of the nightly build, though. I checked the warning. It seems to me that there is no dead code, and the stable build checks pass.

Update: Okay, it seems the field is never read, indeed. But I think it should go in another PR. What do you all think?

mmagician commented 6 months ago

This is a private field, so it it's never read, I think it's alright to remove already here.

autquis commented 6 months ago

Thanks. I removed it. Also, I think further refactoring is possible but I left it for another PR later.

arkworks-rs / poly-commit

Rename nonnative to emulated, as in `r1cs-std` #137