`batch_mul_with_preprocessing` no longer takes `self` as argument - Githubissues

arkworks-rs / poly-commit

A Rust library for polynomial commitments

Apache License 2.0

326 stars 128 forks source link

`batch_mul_with_preprocessing` no longer takes `self` as argument #142

Closed mmagician closed 8 months ago

mmagician commented 8 months ago

Description

Keeping up-to-date with https://github.com/arkworks-rs/algebra/pull/757

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

[ ] Targeted PR against correct branch (master)
[ ] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[ ] Wrote unit tests
[ ] Updated relevant documentation in the code
[ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer

Pratyush commented 8 months ago

Sorry about the typo in the suggestion! Before that, the tests seemed to be failing at this assertion: https://github.com/arkworks-rs/algebra/blob/7357e5e5bddc893da7bee2561be04b31107dde68/ec/src/scalar_mul/mod.rs#L236

mmagician commented 8 months ago

@Pratyush I re-ran CI and indeed, all is well