arkworks-rs / r1cs-std

R1CS constraints for bits, fields, and elliptic curves
https://www.arkworks.rs
Apache License 2.0
133 stars 58 forks source link

Fix dangling batch normalization for twisted Edwards curves #102

Closed weikengchen closed 2 years ago

weikengchen commented 2 years ago

Description

It is discovered that Pedersen commitments are failing. After some debugging, we confirm that it is because normalize_batch, different from batch_normalize, returns the results instead of applying the mutation directly.

This PR fixes so.


Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

N/A:

weikengchen commented 2 years ago

There appears to be another bug regarding Montgomery representations. Will do in a separate PR.