In the implementation of incomplete Montgomery, we use TE's GroupAffine for the intermediate representations. It turns out that ark-ec will refuse to do so, because the coordinates in the Montgomery curve are not valid coordinates for the TE curve.
This PR fixes so, using the appropriate MontgomeryAffine.
Recall that this Montgomery is incomplete---and we require this to be used for only CRS that the possibility of hitting those exceptions is negligible. An explicit error is made when trying to create the point of infinity on the Montgomery curve.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
[x] Targeted PR against correct branch (master)
[x] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[x] Re-reviewed Files changed in the Github PR explorer
N/A:
[ ] Wrote unit tests
[ ] Updated relevant documentation in the code
[ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md
Description
In the implementation of incomplete Montgomery, we use TE's
GroupAffinefor the intermediate representations. It turns out that ark-ec will refuse to do so, because the coordinates in the Montgomery curve are not valid coordinates for the TE curve.This PR fixes so, using the appropriate
MontgomeryAffine.Recall that this Montgomery is incomplete---and we require this to be used for only CRS that the possibility of hitting those exceptions is negligible. An explicit error is made when trying to create the point of infinity on the Montgomery curve.
Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.
Files changedin the Github PR explorerN/A:
Pendingsection inCHANGELOG.md