Sync with ark-algebra: change the location of `BitIteratorBE`

onewayfunc commented 2 years ago

Description

To avoid confusion, ark-algebra reverts is_zero to is_identity for group elements. This PR fixes so.

Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

[x] Targeted PR against correct branch (master)
[x] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[x] Re-reviewed Files changed in the Github PR explorer

N/A:

[ ] Wrote unit tests
[ ] Updated relevant documentation in the code
[ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md

weikengchen commented 2 years ago

The test did not pass but seems to be due to reasons other than this PR. Let me fix the curve side first.

weikengchen commented 2 years ago

I need to check more carefully as I forgot a "cargo update"...

weikengchen commented 2 years ago

Ok, actually we are already using is_zero. The issue is about BitIteratorBE.

arkworks-rs / r1cs-std

Sync with ark-algebra: change the location of `BitIteratorBE` #107

Description