arkworks-rs / r1cs-std

R1CS constraints for bits, fields, and elliptic curves
https://www.arkworks.rs
Apache License 2.0
137 stars 59 forks source link

Change the default field type of the pairing var #111

Closed weikengchen closed 1 year ago

weikengchen commented 1 year ago

Description

When fixing the groth16 library, it seems that the default field type of PairingVar is insufficient---we need to use the BasePrimeField. This PR makes an attempt, and will be finalized when we know if it fixes the issue in Groth16.


Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

N/A:

weikengchen commented 1 year ago

I will wait a bit to merge---I am fixing the code in Groth16 and I am not fully sure if this is needed.

Pratyush commented 1 year ago

I pushed some fixes there too