added rotl function - Githubissues

arkworks-rs / r1cs-std

R1CS constraints for bits, fields, and elliptic curves

https://www.arkworks.rs

Apache License 2.0

137 stars 59 forks source link

added rotl function #116

Closed prismaman closed 10 months ago

prismaman commented 1 year ago

Dear Arkworks team, As I needed a rotl function myself (and rotating to the right 31 times seemed wasteful), I created a rotl function entirely analogous to the rotr function. Kind regards, Sam

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

[ ] Targeted PR against correct branch (master)
[ ] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[ ] Wrote unit tests
[ ] Updated relevant documentation in the code
[ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer

mmagician commented 1 year ago

@prismaman Thanks for the PR and sorry for late review. Would you mind including a unit test for rotl too?