arkworks-rs / r1cs-std

R1CS constraints for bits, fields, and elliptic curves
https://www.arkworks.rs
Apache License 2.0
137 stars 59 forks source link

Fix base scalar multiplication #117

Closed paberr closed 1 year ago

paberr commented 1 year ago

Description

Adds result of base scalar multiplication to self instead of discarding previous value. This seems to be the expected behaviour and this fixes the implementation of the pedersen hash.

closes: https://github.com/arkworks-rs/crypto-primitives/issues/109


Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

paberr commented 1 year ago

It seems like the checks on 052e094 were cancelled (possibly due to my changelog commit?).

paberr commented 1 year ago

Ok, seems to be some issue with the CI (potentially resource limits?). I've ran the tests agains curves locally and they pass.