arkworks-rs / r1cs-std

R1CS constraints for bits, fields, and elliptic curves
https://www.arkworks.rs
Apache License 2.0
133 stars 58 forks source link

Update CI actions: replace `actions-rs/toolchain` with `dtolnay/rust-toolchain`, update `checkout` action to v3 #120

Closed mmagician closed 1 year ago

mmagician commented 1 year ago

Description

CI jobs are failing for apparently no reason in this repo. Maybe related: https://github.com/actions/runner/issues/2468?

I tried to update some workflows, unfortunately no success on my fork, but won't hurt to have actions which are maintained. In follow-up PRs I'll update the rest of the unmaintained actions and also apply the same changes to algebra & curves repos.


Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

Pratyush commented 1 year ago

I think the test is failing because the curve operations are too expensive now. This could be because our tests got more expensive, or because the github machines got weaker, or some combination of the two. We can remove the failing CI test if necessary.

mmagician commented 1 year ago

Yeah that seems to have done it, CI in my fork continues after removingmnt6_753 tests: https://github.com/mmagician/r1cs-std/pull/4. Thanks @Pratyush