Closed slumber closed 1 year ago
Thanks for the PR! Could you fix the errors in CI and then I'll merge this.
Thanks for the PR! Could you fix the errors in CI and then I'll merge this.
I don't think these errors are coming from my PR, perhaps from the CI setup. I don't mind fixing it, but then it would bring some unrelated lines here.
error: call to `.borrow()` on a reference in this situation does nothing
--> src/groups/curves/twisted_edwards/mod.rs:340:44
|
340 | let base_power = base_power.borrow();
| ^^^^^^^^^ help: remove this redundant call
|
= note: the type `ark_ec::twisted_edwards::Projective<P>` does not implement `Borrow`, so calling `borrow` on `&ark_ec::twisted_edwards::Projective<P>` copies the reference, which does not do anything and can be removed
@Pratyush should be fixed now
UPD: or not
@slumber would you like to add a changelog entry for this?
@slumber would you like to add a changelog entry for this?
Yes, will do
Description
closes: #94
See doc-comments for more details.
This part of code could as well be moved into
to_affine
, but this exact behavior might not be expected outside ofscalar_mul
Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.
Pending
section inCHANGELOG.md
// (will add once approved)Files changed
in the Github PR explorer