search

arkworks-rs / r1cs-std

R1CS constraints for bits, fields, and elliptic curves
https://www.arkworks.rs
Apache License 2.0
133 stars 58 forks source link

chore(src): typo fix #131

Closed sqltrigger closed 9 months ago

sqltrigger commented 9 months ago

Hi I fixed a few typo in ./src. Those are comments typos so really minor changes. Have a nice evening.

mmagician commented 9 months ago

Similar: https://github.com/arkworks-rs/curves/pull/185#issuecomment-1855298559

weikengchen commented 9 months ago

At this moment, we have to blank-reject any GitHub submission from accounts whose profile is private. This could likely last for a while.

Please do not try to game the current system. As an investor myself, our industry has started to significantly restrict airdrops only to individuals that provide significant value adds. If more people are gaming this system, the result is that investors and startups will just restrict the airdrop reward even further, making the airdrop system fully centralized. This is not what you want to see.

sqltrigger commented 9 months ago

At this moment, we have to blank-reject any GitHub submission from accounts whose profile is private. This could likely last for a while.

Please do not try to game the current system. As an investor myself, our industry has started to significantly restrict airdrops only to individuals that provide significant value adds. If more people are gaming this system, the result is that investors and startups will just restrict the airdrop reward even further, making the airdrop system fully centralized. This is not what you want to see.

To avoid fictionnal airdrop system centralization (no arkworks-rs airdrop, so it's pure speculation), you're centralizing the github and the way of contributing to the project, that's quite hypocritical.

My profile is private because it's linked to my real job and I wish not to be doxxed.

Those changes certainly aren't major, I get but we're far from the bot attack you seem to describe. There's only been one typo PR in the whole history of this repo.

Also, there's no automatic script for this, the errors all are handchecked. I can work on codepell workflow implementation if wished.

Have a nice sunday.

weikengchen commented 9 months ago

This has started to appear in a large number of repositories across different companies. If this is not your intention, then I apologize, but this is not the only one.

weikengchen commented 9 months ago

Can you explain why you typo-fix a large number of ZK repos?

weikengchen commented 9 months ago

And I recommend you not to follow up with me in this thread and avoid further activity related to arkworks.

You have submitted PRs on typos in many different repos. Continuing engaging with me is going to waste your existing efforts and typos.