search

arkworks-rs / r1cs-std

R1CS constraints for bits, fields, and elliptic curves
https://www.arkworks.rs
Apache License 2.0
133 stars 58 forks source link

Fix visibility of `get_limbs_representations` #139

Open skaunov opened 7 months ago

skaunov commented 7 months ago

(Also additional tiny style fix.)

skaunov commented 7 months ago

My move was just aligning docs and code. X)

So, if it's a first-class citizen of the API, let's rewrite its doc! Ok?

On Thu, Feb 8 2024 at 02:30:46 AM -0800, Kristian Sosnin @.***> wrote:

@.**** commented on this pull request.

In src/fields/emulated_fp/allocated_field_var.rs https://github.com/arkworks-rs/r1cs-std/pull/139#discussion_r1482744608:

 /// This is an internal function that would be reused by a

number of other

  • /// functions
  • pub fn get_limbs_representations(
  • /// functions.
  • pub(super) fn get_limbs_representations( I have code that uses it, don't see why it has to be hidden even.

— Reply to this email directly, view it on GitHub https://github.com/arkworks-rs/r1cs-std/pull/139#discussion_r1482744608, or unsubscribe https://github.com/notifications/unsubscribe-auth/APXLOTYUYB2A2BJG4Q6JVZLYSSSNNAVCNFSM6AAAAABC622JV6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNRZG44DCNBWGA. You are receiving this because you authored the thread.Message ID: @.***>

Pratyush commented 7 months ago

Sure, let's keep it pub and change the doc. @skaunov if you want to update the PR to do that, that would be great

skaunov commented 7 months ago

Will update the PR! Give me some time to collect tiny things like Self in this one for inclusion all at once.

On Fri, Feb 9 2024 at 06:12:40 AM -0800, Pratyush Mishra @.***> wrote:

Sure, let's keep it pub and change the doc. @skaunov https://github.com/skaunov if you want to update the PR to do that, that would be great

— Reply to this email directly, view it on GitHub https://github.com/arkworks-rs/r1cs-std/pull/139#issuecomment-1936002889, or unsubscribe https://github.com/notifications/unsubscribe-auth/APXLOTYWTXOEL5JJC4X6MLDYSYVFRAVCNFSM6AAAAABC622JV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZWGAYDEOBYHE. You are receiving this because you were mentioned.Message ID: @.***>