Bug fix. Changed += to = in FieldVar double_in_place - Githubissues

arkworks-rs / r1cs-std

R1CS constraints for bits, fields, and elliptic curves

https://www.arkworks.rs

Apache License 2.0

133 stars 58 forks source link

Bug fix. Changed += to = in FieldVar double_in_place #142

Open mskrzypkows opened 6 months ago

mskrzypkows commented 6 months ago

Description

Fixed bug in Field_var::double_in_place

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

[x] Targeted PR against correct branch (master)
[x] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[x] Wrote unit tests
[ ] Updated relevant documentation in the code
[ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[x] Re-reviewed Files changed in the Github PR explorer

mmagician commented 6 months ago

Wasn't there a unit test for this before? Could you add one for future proofing?

mskrzypkows commented 6 months ago

I don't see any tests for FieldVar. I'll add some.

mskrzypkows commented 6 months ago

@mmagician What do you think, can we merge it?

mmagician commented 6 months ago

It's currently failing due to recently introduced breaking changes in nightly. Unfortunately there's no automatic fix for these (yet, see WIP), so removing the redundant imports needs to be done manually for now.

mskrzypkows commented 5 months ago

@mmagician, @Pratyush removed unused imports, should pass now.

mskrzypkows commented 4 months ago

🤔 Something changed in algebra with ark_std::sync?

mskrzypkows commented 4 months ago

Can we rerun failing no_std check?