arkworks-rs / r1cs-std

R1CS constraints for bits, fields, and elliptic curves
https://www.arkworks.rs
Apache License 2.0
133 stars 58 forks source link

Remove dependency on ark-relations/std #147

Open mzabaluev opened 1 month ago

mzabaluev commented 1 month ago

Description

The dependency on ark-relations/std is entirely unneeded. Currently it adds some dependency dead weight for us due to pulling an outdated version of tracing-subscriber (https://github.com/arkworks-rs/snark/issues/356).


Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

Pratyush commented 1 month ago

I think it would be preferable to update the dependency in ark-relations. If you'd like to look into that I can help with that, otherwise we can look into it in a little while.

mzabaluev commented 1 month ago

I think it would be preferable to update the dependency in ark-relations.

Sure, but why not remove useless dependencies from the dependency tree as well? This potentially improves build times for library's consumers, and I can't see any downsides.