Closed tsunrise closed 3 years ago
The change looks good. Although this is a breaking change, the Radix2Domain
in r1cs_std
is not used very often downstream (most are using the Radix2Domain
in ark-ff
), and I think renaming makes sense.
will wait for @ValarDragon for a final review
Description
Current
Radix2Domain
does not support non-constant offset. This PR adds that functionality.Highlighted Changes:
Radix2Domain
will be renamed toRadix2DomainVar
Radix2DomainVar
will offset that isFpVar
instead ofF
Radix2DomainVar::interpolate_and_evaluate
will specialize according to whetherself.offset
is constant or not.closes: #64
Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the Github PR explorer