arkworks-rs / r1cs-tutorial

Tutorial for writing constraints in the `arkworks` framework
Apache License 2.0
198 stars 74 forks source link

README for part #1 of the R1CS Tutorial is misguiding #11

Open fwmm opened 1 year ago

fwmm commented 1 year ago
∂ ## Summary of Bug The README for the _merkle tree example_ in the R1CS tutorial incorrectly states that it will show how to invoke a SNARK when actually the example is only about generating the constraints and verifying satisfiability directly using the witness input itself. This is confusing for beginners trying to learn arkworks. ## Version commit 5d3a9022fb6deade245505748fd661278e9c0ff9 ## Steps to Reproduce Compare the README to the example code.
neocarmack commented 4 months ago

yes. The example is simply filling the merkle path to verify, it is not a construction of r1cs. The knowledge is exposed, not a zero knowledge proof.