arkworks-rs / r1cs-tutorial

Tutorial for writing constraints in the `arkworks` framework
Apache License 2.0
203 stars 79 forks source link

Test for 'Verifying a single transaction'; minor improvements #9

Closed pmikolajczyk41 closed 2 years ago

pmikolajczyk41 commented 2 years ago

Description

When working on the exercises I encountered two annoying things:

This PR:

Checklist:

weikengchen commented 2 years ago

Let me clean it up a bit, apparently the remaining tests have been failing for more than one year.

pmikolajczyk41 commented 2 years ago

@weikengchen I'm afraid that unused variable is the thing that we should ignore in CI (or prepend corresponding object names with _), at least for such (tutorial) repository

I'm not so sure about no-std checks though

weikengchen commented 2 years ago

Let me merge it first. The no-std check is pretty weird, and I believe a larger refactoring is likely needed for this to be compatible with 0.4.0.

pmikolajczyk41 commented 2 years ago

@weikengchen thank you!