arkworks-rs / ripp

Argument systems for inner pairing products
https://eprint.iacr.org/2019/1177
Apache License 2.0
41 stars 15 forks source link

Parallelized some things #21

Closed rozbb closed 3 years ago

rozbb commented 3 years ago

This requires some new associated type constraints, specifically what kind of messages and keys we can use for commitments. I don't thing Send + Sync are at all unreasonable assumptions for a cryptographic message type or a cryptographic key type, though.

The other thing I did was use cfg_iter! to parallelize a bunch of functions in ip_proofs. This conflicts with the more direct par_iter notation used in the sipp crate. I'm not sure which one you prefer, so let me know and I'll make the change.

Lastly, this does not compile without the most recent changes (https://github.com/arkworks-rs/utils/pull/16) to the utils crate. The issue is that the cfg_iter! wasn't using the rayon iter before the new changes.

rozbb commented 3 years ago

This PR compiles again and requires no changes to utils. I've also updated the deps to v0.2 wherever appropriate

Pratyush commented 3 years ago

Thanks for following up on this, I'll merge once CI passes!