added Edwards curves for MNT-298 and MNT-753

arkworks-rs / snark

Interfaces for Relations and SNARKs for these relations

https://www.arkworks.rs

Apache License 2.0

776 stars 209 forks source link

added Edwards curves for MNT-298 and MNT-753 #217

Closed weikengchen closed 4 years ago

weikengchen commented 4 years ago

With the help of Pratyush, we found Edwards curve parameters for MNT-298 and MNT-753. The former was easy. The latter took ~$1k AWS credits together with half a month of two machines in RISELab.

Comments are made extensive to aid others in case they need to construct an Edwards curve and want to know how to properly write the parameters in Zexe.

Pratyush commented 4 years ago

Thanks for the PR @weikengchen ! I just merged a different PR #213 which slightly changes the convention regarding naming of curves; I'd appreciate if you could modify the PR to be in line with the new convention:

edwards_xxx -> ed_on_xxx.

weikengchen commented 4 years ago

no problem. will do the changes. will push later tonight

weikengchen commented 4 years ago

I made the changes (but seems CI would not work unless conflicts are resolved, which I tried but failed from my end)

weikengchen commented 4 years ago

aha, let me merge with the upstream in my repo and then make a new one.