arkworks-rs / snark

Interfaces for Relations and SNARKs for these relations
https://www.arkworks.rs
Apache License 2.0
788 stars 209 forks source link

Consistent bit order across ToBitsGadget? #238

Closed weikengchen closed 4 years ago

weikengchen commented 4 years ago

In the current library, we know that:

Would it be worthwhile to have a global consistency such that all to_bits are big-endian OR little-endian?

Pratyush commented 4 years ago

Yeah, it's been on my stack as I've been going through the refactor. Maybe a good idea would be to have to_bits_le and to_bits_be, and define one of them in terms of the other

Pratyush commented 4 years ago

Fixed, by moving things to to_bits_le