Closed Pratyush closed 4 years ago
Did you choose to use an explicit bool for performance reasons?
I did omit the flag handling for affine structs for performance reasons, but I should check that it actually makes a difference by benchmarking.
This is very useful! I actually might need something like this soon. That said, I'm highly in favor of making it compatible with the normal decompression. @Pratyush do you think you're going to decide by benchmarking?
@kobigurk @paberr I think I'll just make it compatible with normal decompression, because I suspect most of the overhead is due to subgroup checks, and not due to bit manipulation. (I'm writing benchmarks right now to verify this)
I suspect most of the overhead is due to subgroup checks, and not due to bit manipulation.
Indeed, most of the overhead is due to the prime-group check.
Add unchecked serialization and deserialization, for the case when one knows that the serialized output will be stored in a trusted location (for example: serialized and deserialized by the same machine).
cc @ChaitanyaKonda @iAmMichaelConnor, this might solve your use case in a cleaner way.
cc also @kobigurk @paberr