CondSelectGadget for `UInt`s

arkworks-rs / snark

Interfaces for Relations and SNARKs for these relations

https://www.arkworks.rs

Apache License 2.0

770 stars 207 forks source link

CondSelectGadget for `UInt`s #312

Closed nirvantyagi closed 3 years ago

nirvantyagi commented 3 years ago

This pull request implements CondSelectGadget for UInt constraint variables. UInt8 is implemented directly, while a macro is included to generate the implementation for UInt16, UInt32, UInt64.

nirvantyagi commented 3 years ago

A couple of things for review:

Is the tracing macro being used correctly? Should any of the inputs be skipped?
Is the behavior for selecting the value when the inputs have no values correct?

Pratyush commented 3 years ago

Hi @nirvantyagi, do you mind re-opening this PR against ark-r1cs-std? Thanks!