Finalize

[npwardberkeley]

Initial attempt to resolve #333

[weikengchen]

This fmt issue may have something to do with the Rust version, aka

• is it 1.48.0?
• is it stable?

Because some other versions, and some nightly, have different cargo fmt preferences.

[weikengchen]

let me cc @Pratyush and @ValarDragon here for some feedback on the API.

[weikengchen]

It seems that all the comments have been resolved, with this one needing more discussion:

whether or not to keep this function

fn reduce_constraint_weight(&mut self) {

Since this function is now fn rather than pub fn, I think for now it is okay to remove this function. The function is only, previously used by Marlin (who needs to change accordingly).

Nick, what do you think?

[npwardberkeley]

Yes, that makes sense!

[weikengchen]

Let me cc @Pratyush and @ValarDragon for a final pass

[Pratyush]

I left a comment about None

[weikengchen]

Based on the discussion above, I think we will keep None for now and redirect it to self.inline_all_lcs(). This is the last change needed/ In the future, different treatments may occur, such as reducing the amount of symbolic LC.

[weikengchen]

Checks pass :) Pratyush and Dev, if it looks good, feel free to merge or do some final edits.

[weikengchen]

One more: we need to export OptimizationGoal here:

https://github.com/npwardberkeley/snark/blob/finalize/relations/src/r1cs/mod.rs#L21

Otherwise, Marlin could not find it.

[weikengchen]

add one to enforce that set_optimization_goal must check that no constraint/variable has been written.

        num_instance_variables: 1,
        num_witness_variables: 0,
        num_constraints: 0,
        num_linear_combinations: 0,

(sorry to bother Nick---I could add them if you add me as a PR repo's writer)