Prepare ark-snark for the new updates in ark-algebra

weikengchen commented 1 year ago

Description

This draft PR has several changes: (1) add patching, (2) change ark-test-curves feature to the curve one temporarily before a corresponding PR in ark-algebra is merged, and (3) fix a confusing "type annotations needed".

Since (2) is in a pending PR, it would be best not to merge this PR before that one is done, specifically giving that we are working on the snark repo.

https://github.com/arkworks-rs/algebra/pull/461

Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

[x] Targeted PR against correct branch (master)
[x] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[x] Re-reviewed Files changed in the Github PR explorer

N/A:

[ ] Wrote unit tests
[ ] Updated relevant documentation in the code
[ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md

Pratyush commented 1 year ago

This LGTM modulo the comment

weikengchen commented 1 year ago

^ The change above (using CanonicalSerialize + CanonicalDeserialize) is done. But, it depends on https://github.com/arkworks-rs/algebra/pull/476

weikengchen commented 1 year ago

Closed --- needs to rebuild the PR.

arkworks-rs / snark

Prepare ark-snark for the new updates in ark-algebra #362

Description