The is_satisfied() method returns Result<bool> and so testing the result with
.is_ok() would pass for both Ok(true) and Ok(false). unwrap()ping
and asserting that true is returned fixes this.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
[x] Targeted PR against correct branch (master)
[x] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[ ] Wrote unit tests
These are the unit tests.
[x] Updated relevant documentation in the code
[ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
Description
The
is_satisfied()method returnsResult<bool>and so testing the result with.is_ok()would pass for bothOk(true)andOk(false).unwrap()ping and asserting thattrueis returned fixes this.Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the Github PR explorer