This PR changed a few lines in src/perf_trace.rs on atomic variable accessing and modifying. As far as I can see these duplicated fetch_adds makes the entire macro non-atomic and should be merged into one.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
[x] Targeted PR against correct branch (master)
[x] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[ ] Wrote unit tests
[ ] Updated relevant documentation in the code
[x] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[x] Re-reviewed Files changed in the Github PR explorer
I could use some suggestions on how such unit test can be designed. And I believe this is a merely bug fix and no relevant documentation needs to be updated.
Description
This PR changed a few lines in
src/perf_trace.rson atomic variable accessing and modifying. As far as I can see these duplicatedfetch_adds makes the entire macro non-atomic and should be merged into one.Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the Github PR explorerI could use some suggestions on how such unit test can be designed. And I believe this is a merely bug fix and no relevant documentation needs to be updated.