arkypita / LaserGRBL

Laser optimized GUI for GRBL
http://lasergrbl.com
Other
1.27k stars 497 forks source link

English text only #1314

Open pebcz opened 3 years ago

pebcz commented 3 years ago

"* Options" text is in English only for first 2 types - may be it's defined "hard" in RasterToLaserForm.cs, here? GbLineToLineOptions.Text = RbLineToLineTracing.Checked ? "Line To Line Options" : "Dithering Options"; options

arkypita commented 3 years ago

Fixed https://github.com/arkypita/LaserGRBL/commit/6218e54068a9b90cd0780530e709cd3472d8e31c

There may be others like this one.

pebcz commented 3 years ago

Question: you add new items (LineToLineOptions, DitheringOptions) to Strings.resx, but necessary items are also in RasterToLaserForm.resx (GbLineToLineOptions.Text - I think it's not used in any place in source code) - is it correct?

arkypita commented 3 years ago

Question: you add new items (LineToLineOptions, DitheringOptions) to Strings.resx, but necessary items are also in RasterToLaserForm.resx (GbLineToLineOptions.Text - I think it's not used in any place in source code) - is it correct?

When you put a control on the form, text label, groupbox, checkbox or other, visual studio create a localization entry automatically in the form resx. It is there and you cannot avoid having it.

But if you want to put a dynamic text in this control, for example that shows a state that changes according to the conditions, then you have to manage the translation manually.

The original writing remains in the translation file, but in practice apart from the first very short initial drawing, it will never be displayed because the code will immediately set the one corresponding to the status.

pebcz commented 3 years ago

newly found:

filling_speed engraving_speed