LaserGrbl - laser movement by double-clicking does not work when the soft limit is switched on. ($ 20 = 1)

[igortv1]

Describe the bug when the soft limit is enabled, double-clicking on the selected XY location does not work. the laser start run up at the top right and stops by hard limit. if the soft limit is switch off, everything works as it should and the laser moves to the given location. I think it's a SW bug.

To Reproduce just double-click on a specific location of the lasergrbl area.

Expected behavior double-clicking on the XY position should move the laser to that position, even when the laser mode is switched on.

Hardware and software configuration (please complete the following information):

• Windows version W7 ultimate 64bit
• Engraver brand and model DIY CNC3018
• Grbl version 1.1f
• LaserGRBL version 4.6.1

Additional context Hello, I'm here for the first time and forgive me for not knowing where to turn with the problem. Thank you for understanding Igortv1.

config_grbl_009-SL_ena.txt

[arkypita]

Thanks for the detailed report, I will check the situation as soon as possible.

[arkypita]

I have tested with my OLM1 with both homing and soft limit, as per your config, and it work for me. Are you sure that it is not an issue of your engraver firmware?

Here a video: https://youtu.be/Z-Bvr9ltBNE

[igortv1]

Thank you for your time and video, I haven't flashed FW even once. when there is an error, then both the machine and the cursor move identically. therefore, I assume that the machine will be OK. it occurred to me that there could still be an error in setting the directions of the XY axis ($ 3, $ 23). I'm going to check it out.

[igortv1]

so i don't know ... directions, even homing positions ($ 3 $ 23) are fine. I simulated the problem several times today, but after rewriting these two $ variables, I couldn't simulate it anymore. if I made a mistake somewhere, I can't repeat it again. it draws me to the negative values ​​of the desktop, when double-clicking was a problem. Did it still occur to me that the problem could be caused by an unreliable eeprom? for multiple writes to eeprom, it seems to work as it should.

I managed to catch the problem simulation and uploaded it here: https://ulozto.cz/tamhle/bAiFzDIubVoA#!ZGLlZQR1LzEzMQEuZQLmLzH3ZGD5DJ9JLxZko0kxYGSdBGp5

maybe something can be read from the coordinates.

(HW limits remained from the previous experiment)

[igortv1]

After a long time I am returning to the problem, because I have ruled out a FW bug, and also a HW bug of the GRBL controller.

problem 21.10.2021 (23.1.2022 problems remain also in v4.7.1, also 30.3.2022 v4.8.0)

Now, after upgrading CNC3018 pro to expand Y and Z axis, I also installed a new GRBL controller with fw 1.1f to rule out a possible HW/FW problem in the master controller. Unfortunately, nothing has changed, the problem persists even after installing the new one. I'll try to describe it again...

W10 64bit LaserGRBL v4.8.0 FW v1.1f

SOFTLIMIT has two problems:

1 - double click lasergrbl - it moves right up, (as if it wants to do homing right up) then STOPS ON SW LIMIT. ALWAYS ON ONLY IF $20 Soft Limits enable = 1 if $20=0 is off, everything is fine, the double click works OK. verified multiple times in a row.

2 - offline controller does not work when $20 softlimit = 1. when $20 = 0 it works OK.

GRBL still at $20=1 does not respond to positioning from the offline controller. on the display the symbols correspond 
to the buttons.
only switching $20 to 0 and cold restart will help. (the reset button on the GRBL board is not enough to press)
if you need to verify something, send some video, etc., I will be happy to provide feedback. 

And another request, I don't know this, maybe it belongs in a new thread, sorry: it would help me if I could introduce a switch so that LaserGrbl doesn't take Z commands into account. Very often I need to run milling subfiles to work with LASER and I have to edit all the Z feeds out of the subfile beforehand. switching would be a quick and elegant solution to run the subfiles directly without editing. Thank you.

config.txt

[igortv1]

sorry, close, open, it is new for me.

[igortv1]

link on video is there: https://ulozto.cz/tamhle/ycXSy7LXYE2n#!ZJD4AwR1MzLkMGN4LGt5MGtkAwp3owWSJJ5UK1OXqySbA2L1

[StuartB4]

Are you using the offline controller at the same time as the usb is connected. I know them 3018 machines don't like it if both are connected.

[igortv1]

no. usb is disconnected, when offline controll is in use. only for change $20 i switch on usb (grbl controll disconected).

[igortv1]

please click on right button download free but slow .

[StuartB4]

Ok, got the video. Noticed when you click connect the cordinates in the top right of the main window are not X: 0.000 and Y: 0.000. Like this.

I have these both set and LaserGRBL always starts with X: 0.000 and Y: 0.000 when I connect.

[igortv1]

i have this the same, except hard reset. i am enabled hard reset, and situation was changed. after doubleclick now don't any move and written "travel exceeded". it seems to me as if grbl doesn't know where the home position is at this point.

[igortv1]

of course with $20=1. with $20=0 everything is still OK

[igortv1]

I'm still drawn to the fact that the machine, when the soft limit $20=1 is enabled, for some reason forgets that it has a working zero on the bottom left (it doesn't look where it is), but instead assumes the zero is right side up and moves in that direction. With the $20=0 soft limit turned off, this error does not occur. I guess I'm not able to judge more. I just don't understand why this can't be simulated elsewhere. Maybe I have something wrong in the GRBL configuration and I don't see it? Or am I the only one who has encountered this... I have been living with this for about a year and I would love to solve it with your help. Thank you StuartB4 and arkypita for trying to help me.

[arkypita]

Please read what's here inside, this is the command LaserGRBL send.

$J=G90 is a Jog command using absolute coordinates. Commanded position is X30 Y42, speed F1000

The travel exceeded is generated as an error by the Grbl controller, as response to this command. You should try to understand why the macine is refusing this positioning command.

If you do jog using arrows, it works or not?

I think you could have a better help on grbl firmware github page.

[igortv1]

Thanks for the response. Yes, I posted those lines precisely because they should be executable. they are two doubleclics. before i enabled hard reset on program startup in the config (according to stuart), there were soft limit coordinates on double click and no error message. and that's why the machine started moving right up. as in this picture I attach now.

the positioning with jog always works correctly (even at $20=1). the firmware also accepts the SW limit settings, (which is 1mm from the HW limit) and allows positioning along X286.5 Y286.5.

everything always works as it should, with the exception of the double click at $20=1. At $20=0, the double click works fine. But of course the soft limit doesn't work, which is very annoying.

[Herbi5]

Hi, I am facing the same thing. When double clicking the canvas (Engraving preview) the laser head just continues passing the click point and stops at hard/soft limits. I noticed that in absolute position command ($J=G90X1502.00Y1502.00F1000) generated by double click, there are coordinates of X-axis maximum travel $130 and Y-axis maximum travel $131 in my case 1500 mm + 2 mm for Homing switch pull-off distance. My homing position is at upper right corner where end switches are located and then I am pulling back X-1500 Y-1500 (negative machine space) where I set zero point (G92) --> physical left, bottom corner. When jogging with arrows keys setting the relative coordinates (G91) everything works well. Behavior is same as igortv1 observes and as shows in his first video: https://ulozto.cz/tamhle/bAiFzDIubVoA#!ZGLlZQR1LzEzMQEuZQLmLzH3ZGD5DJ9JLxZko0kxYGSdBGp5.

Here too, one can notice upon clicking the value set by LaserGRBL is $J=G90X287.50Y177.00F1000 (287.50 and 177.00 are his maximum travel values according to his config.txt presented here) instead setting it to cca. $J=G90X30.00Y40.00F1000 where the click on the canvas appeared! --> Seams to be some bug in code of LaserGRBL when clicking on the canvas with set soft limits and negative machine workspace.

Grbl version 1.1h LaserGRBL version 4.8.0

[arkypita]

I tested what you reported. Again, with an official GRBL firmware, the behavior is correct with no issues. The problem you are reporting is probably caused by incorrect implementation of a custom firmware.

https://user-images.githubusercontent.com/8782035/206917253-b9531879-c15c-4ebf-8e82-3a986a5cb694.mp4

[arkypita]

Ok, I have found what point of the code change the clicked coordinates to the maximum travel coordinates. Is it a safety feature that try to limits the jog command, to the maximum machine travel.

[arkypita]

Ok, you are right. It does not happens to me because I don't have soft limits, if I enable them I have the same effect.

[arkypita]

Apparently, the code that limit jog to soft limits seem to be too complicated.

Math.Min(Math.Max(target.X, -mWCO.X), (float)Configuration.TableWidth - mWCO.X); Math.Min(Math.Max(target.Y, -mWCO.Y), (float)Configuration.TableHeight - mWCO.Y);

can be simplified to

Math.Min(target.X, (float)Configuration.TableWidth); Math.Min(target.Y, (float)Configuration.TableHeight);

But I have to think about possible side effects

[Herbi5]

I was looking your sources yesterday evening and came to the same lines of code but I could not debug it since I currently have no access the to the machine. I was just debugging using emulator but there the soft limits doesn't work or are not implemented (do not report error if they are overrun). When I get machine to machine I will debug this part so that will suit my needs, unless you will already introduce some modification. O I see you are working already on it.

Good job tnx.

[arkypita]

if you are able to build from source code, please test by yourself and let me know. I have no access to a machine now (I am using a arduino board, but no hardware connected)

[Herbi5]

I will test this end of the week, since the machine is at my sister. I am modifying it for her to do the job what she wants (large draw plotter).

So I should try your simplification:

Math.Min(target.X, (float)Configuration.TableWidth); Math.Min(target.Y, (float)Configuration.TableHeight);

I will do that and I will let you know the results in a week :)

Regards,

[Herbi5]

Hi, I managed to test your simplification and it works as expected. This was short test, so I could not identify if this implementation somehow influences execution in other sections of the code (side effect you mentioned).

https://user-images.githubusercontent.com/120283386/207718151-c8964d69-50c2-4dbf-8b47-2296b5b6c0af.mp4

Thanks for the proposed solution and keep up the good work. I might some day encourage myself and translate the GUI into Slovene. ;)

[igortv1]

Thank you also for clarifying the problem and fingers crossed. Also happy New Year's Eve and many good attacks in new year 2023.