arkypita / LaserGRBL

Laser optimized GUI for GRBL
http://lasergrbl.com
Other
1.22k stars 486 forks source link

Option to specify line endings on generated GCode #2036

Closed HumbertoL closed 1 year ago

HumbertoL commented 1 year ago

Is your feature request related to a problem? Please describe. I'm using the Creality Laser Engraver CR Falcon SE which shows the firmware as Grbl 1.3a.

The generated GCode does not appear to work on this particular machine when exported to a file.

If I manually convert the line endings from CRLF to LF ("\r\n" to "\n") on the generated file, then the machine will take the file just fine.

The line endings work correctly in the paid software LightBurn.

Describe the solution you'd like Some way to indicate that I want LF endings instead of CRLF. Ideally, this would be under export options in the Advanced Options.

Describe alternatives you've considered Another solution might be to add some kind of plugin for post-processing of the file. That doesn't seem very practical though since it would be a much larger change.

Additional context

UPDATE: I created a PR to solve the issue. I can confirm that the line endings are generated correctly for my machine with these changes.

HumbertoL commented 1 year ago

This issue has been fixed