arkypita / LaserGRBL

Laser optimized GUI for GRBL
http://lasergrbl.com
Other
1.2k stars 485 forks source link

Visualisation Error #787

Open GrahamJB opened 4 years ago

GrahamJB commented 4 years ago

Just FYI. Following GCode producxes a visualisation error, the second set of lines are above the first. Although the visualisation is incorrect while processing the file the blue+ follows the correct path.

$32=1 (TracingTest Gcode Generator-V2) (Focus Test - Draw 11 lines with a Z axis step) (Power for Lines 250, Feed 300) (Power for reference marks 350, Feed 300) (Line Height 10, Spacing 2, Z Step 1 mm) G94 G17 G21 G0 G90 X0 Y0 G91 M3 F300 S350 (Draw Reference Marks) G1 Y1 G0 X2 Y-1 G1 Y1 G0 X2 Y-1 G1 Y1 G0 X2 Y-1 G1 Y1 G0 X2 Y-1 G1 Y1 G0 X2 Y-2 G1 Y2 G0 X2 Y-1 G1 Y1 G0 X2 Y-1 G1 Y1 G0 X2 Y-1 G1 Y1 G0 X2 Y-1 G1 Y1 G0 X2 Y-1 G1 Y1 G0 G90 X0 Z0 Y2 G91 G0 Z-5 S250 G1 Y10 G0 X2 Y-10 Z1 G1 Y10 G0 X2 Y-10 Z1 G1 Y10 G0 X2 Y-10 Z1 G1 Y10 G0 X2 Y-10 Z1 G1 Y10 G0 X2 Y-10 Z1 G1 Y10 G0 X2 Y-10 Z1 G1 Y10 G0 X2 Y-10 Z1 G1 Y10 G0 X2 Y-10 Z1 G1 Y10 G0 X2 Y-10 Z1 G1 Y10 G0 X2 Y-10 Z1 G1 Y10 G0 G90 X0 Y0 Z0 M2 (END OF PROGRAM)

image

arkypita commented 4 years ago

Damn! I have write LaserGRBL thinking that only one G code or M code is valid on a single line. The issue is on line G0 G90 X0 Z0 Y2, where LaserGRBL parse the G0 and skip G90.

GrahamJB commented 4 years ago

A small problem,

Personally I hate it when I do things like that so I sympathise.

Just remember that if design and programming were easy everyone would want to do it!

Graham Bland

From: arkypita [mailto:notifications@github.com] Sent: 23 November 2019 20:02 To: arkypita/LaserGRBL Cc: GrahamJB; Author Subject: Re: [arkypita/LaserGRBL] Visualisation Error (#787)

Damn! I have write LaserGRBL thinking that only one G code or M code is valid on a single line. The issue is on line G0 G90 X0 Z0 Y2, where LaserGRBL parse the G0 and skip G90.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/arkypita/LaserGRBL/issues/787?email_source=notifications&email_token=ABN5WWCDB5ZUPZO77NAQUHDQVGD23A5CNFSM4JQ3MYHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE74TFI#issuecomment-557828501 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABN5WWAQNK7C7ONBMR5NTTDQVGD23ANCNFSM4JQ3MYHA . https://github.com/notifications/beacon/ABN5WWDR7FSDXK26PCBFDCTQVGD23A5CNFSM4JQ3MYHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE74TFI.gif