Add 'github.com/gorilla/websocket' to 'go.mod' file

arl / statsviz

🚀 Visualise your Go program runtime metrics in real time in the browser

MIT License

3.19k stars 121 forks source link

Add 'github.com/gorilla/websocket' to 'go.mod' file #36

Closed ShoshinNikita closed 3 years ago

ShoshinNikita commented 3 years ago

First, thank you for the great tool! It really helps to visualize and analyze runtime stats

I noticed that package websocket is a copy of github.com/gorilla/websocket. I would suggest to remove it from the repo and add to go.mod file. Even if there are some changes, it's better to create a fork. What do you say?

arl commented 3 years ago

When I started the project, statsviz http handlers were installed with an init, _ import like you'd do with net/http/pprof handlers. I wanted the library to be self-contained that's why I included websocket in the codebase. I think you're right, now that's not useful anymore and it can even be counterproductive for projects which already import websocket as they would have a duplicate dependency. Will add this to go.mod.

Thanks for reporting.