search

arl / tmux-gitbar

Git in your tmux status bar
GNU General Public License v3.0
169 stars 16 forks source link

tmux-gitbar.conf needs to exist outside the repo #37

Closed alexkornitzer closed 7 years ago

alexkornitzer commented 7 years ago

Could you allow the option to have the tmux-gitbar.conf exist outside the repo? Apologies if this functionality already exists. Having the file exist in the repo makes it difficult to maintain the file across systems. I have tmux-gitbar as a submodule in my home folder setup which means I cannot manage the tmux-gitbar.conf across my machines. The conf file should really exist in the home folder anyway: ~/.tmux-gitbar.conf

arl commented 7 years ago

Hi Alex. I understand your problem, but in the currently state of things, i dont think you can have it versioned without modifying tmux git bar code. Why dont you fork it and allow a different path to tmux-gitbar.conf? In case its not good enough for you i May resolve this when i have a bit of time

Le 17 nov. 2016 15:49, "Alex Kornitzer" notifications@github.com a écrit :

Could you allow the option to have the tmux-gitbar.conf exist outside the repo? Apologies if this functionality already exists. Having the file exist in the repo makes it difficult to maintain the file across systems. I have tmux-gitbar as a submodule in my home folder setup which means I cannot manage the tmux-gitbar.conf across my machines. The conf file should really exist in the home folder anyway: ~/.tmux-gitbar.conf

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/aurelien-rainone/tmux-gitbar/issues/37, or mute the thread https://github.com/notifications/unsubscribe-auth/AAdF6ox88uDBoAQ84o8_ht3QU4el0FkIks5q_GlkgaJpZM4K1ZM1 .

alexkornitzer commented 7 years ago

Hi Aurelien. If you are okay with me applying the changes I am happy to have a go at implementing this. Would you want me to PR back into the project or is this not the sort of feature you would want. If so what level would you want it at hardcoded to HOME or completely user definable?

arl commented 7 years ago

Thanks, a PR would be great! It believe it would be nice to have a sensible default for the config file location (in $HOME) that remains overridable by the user. Currently, tmux.gitbar.conf is auto-generated if it's not found in the project root directory.

alexkornitzer commented 7 years ago

Awesome, already on the case. I nearly have it working so expect a PR soonish!

arl commented 7 years ago

Just have a look at the unit and integration test suite to be sure to not break nothing😉. But dont bother run them locally, they will be be run on Travis as soon as you open the PR. Cheers

Le 17 nov. 2016 17:47, "Alex Kornitzer" notifications@github.com a écrit :

Awesome, already on the case. I nearly have it working so expect a PR soonish!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/aurelien-rainone/tmux-gitbar/issues/37#issuecomment-261300527, or mute the thread https://github.com/notifications/unsubscribe-auth/AAdF6gvTtrew62CrByWh8Hb7GgiOKsFXks5q_IUvgaJpZM4K1ZM1 .

arl commented 7 years ago

fixed in #38