search

arlionn / stata

连玉君老师的stata程序、讲义和培训资料
61 stars 35 forks source link

Attribution #1

Open wbuchanan opened 7 years ago

wbuchanan commented 7 years ago

While I cannot read most of the text, I would suggest adding appropriate attribution to all of the copied examples instead of just one. More importantly, you could just fork brewscheme and submit a PR about documentation in other languages. I'm definitely open to having documentation in other languages if it would help other users and it could make it easier for other users to find the help/support they need with things.

arlionn commented 6 years ago

Dear Prof. wbuchanan, I am sorry to reply you so late.
I registered my account at Github in september, and few weeks later, I found the Chinese version Github, named Gitee. So, I turned to Gitee, and almost forget Github. This afternoon, a friend told my about your issue. I am greatly thank you for your help package brewscheme. It has been used in my teaching lectures and my research. As I am not familar with Github, I did not submit any PR to you. I will try to learn about it, and submit a PR to you.
Thanks.
Yours Yujun Lian

wbuchanan commented 6 years ago

@arlionn GitHub is just a hosted version of git. A pull request is something you would submit as a way of contributing your code to the work of someone else; in essence you are requesting that the repository owner pull your code/fix into their codebase. Submitting an issue, on the other hand, is just a way of making the repository owner aware that there may be an issue.

I’m not completely familiar with restrictions to accessing websites from China, but that may be one reason for the issues (e.g., there is a request to download content from its source that never takes place). There also seems to be another Chinese group/individual with a presence on GitHub that you may find helpful/useful @Stata-Club.