search

arlolra / ctypes-otr

js-ctypes wrapper for libotr
Mozilla Public License 2.0
29 stars 7 forks source link

Disable message logs upon using private otr chats. #49

Open redragonx opened 9 years ago

redragonx commented 9 years ago

Pidgin-otr does this by default.

arlolra commented 9 years ago

Ah, right. In Tor Messenger we've disabled all logging. But for Instantbird, this will be a useful feature.

azadi commented 9 years ago

Related: warn the user if logging is enabled (if the user explicitly enabled it).

arlolra commented 9 years ago

Pushed a patch for the first part of this there. It depends on merging something upstream though. https://bugzilla.mozilla.org/show_bug.cgi?id=1175374

Working on the warning next.

vqhuy commented 8 years ago

@arlolra how do you display the warning to users? Should we show it in conversation window (using systemMessage method)?

arlolra commented 8 years ago

@c633 I think using the notification box would be preferable, since we'll eventually want to conveniently add actions like "disable logging".

Unfortunately, at present, disabling logging doesn't affect the current conversation. I had a patch for that but it got stalled on a dependency, which I see has now resolved. I should pick that up soon. https://bugzilla.mozilla.org/show_bug.cgi?id=1175706

Even more unfortunate is that the logging flag has no granularity and can't be applied to individual conversations. The other patch above, which also stalled, is perhaps too fined grained and applies to messages themselves. Not sure why I did that. I need to revisit this whole issue.

Anyways, yes, a notification box with perhaps a pref to permanently dismiss the warnings would be a good first start. See code in ui.js around notifyBox for an example.