search

arlolra / ctypes-otr

js-ctypes wrapper for libotr
Mozilla Public License 2.0
29 stars 7 forks source link

Useless blank lines if receiver is not using OTR #54

Closed clokep closed 9 years ago

clokep commented 9 years ago

From @PrezNattyGibbs

When I talk to you on Instantbird, your first few messages usually come through with an extra space under them. Not sure why or if this is a big deal.

instantbird

Maybe we should trim() things before display?

arlolra commented 9 years ago

No, these are the whitespace tags that OTR appends. https://github.com/arlolra/ctypes-otr/blob/master/chrome/content/libotr.js#L353

You see that they stop as soon as you get a message back from your contact in plaintext after sending them. After one roundtrip, OTR knows to stop using them.

We can turn them off by removing https://github.com/arlolra/ctypes-otr/blob/master/chrome/content/libotr.js#L358 but then your encryption isn't so opportunistic.

clokep commented 9 years ago

@arlolra I think you missed what I'm suggesting. The user on the other side of the connection is what I'm concerned about. That's a screenshot from someone NOT using OTR.

arlolra commented 9 years ago

@clokep Yup, totally missed that :)

Good idea. I'll submit a patch.

arlolra commented 9 years ago

https://bugzilla.mozilla.org/show_bug.cgi?id=1178550

arlolra commented 9 years ago

r+'d upstream