search

arlolra / ctypes-otr

js-ctypes wrapper for libotr
Mozilla Public License 2.0
29 stars 7 forks source link

Don't close notification until verification succeeds. #68

Closed tnull closed 8 years ago

tnull commented 8 years ago

This fixes #62: the notification bar is hindered from being closed by the verification dialog. However, while the XUL documentation states this can be done by throwing an error in the eventCallback function of appendNotification, this did not work for me. I instead put the throw into the callback function of the button.

I also opened a post on stackoverflow on this issue, since I don't see why the method described in the documentation should not work.

arlolra commented 8 years ago

Thanks for the pull. Can you amend the patch (after verifying my review) and force push to your branch?

tnull commented 8 years ago

Ok, my patch is updated to include the return true statement rather than throwing. And the description how to use the Error in the eventCallback should also be gone from the XUL documentation soon, too (see stackoverflow) .. :)

arlolra commented 8 years ago

Great! Merged in 40f7542d1e3a8a3c490f3dcc2a08af45c273e245