Closed tnull closed 8 years ago
Thanks for the pull. Can you amend the patch (after verifying my review) and force push to your branch?
Ok, my patch is updated to include the return true
statement rather than throwing.
And the description how to use the Error in the eventCallback should also be gone from the XUL documentation soon, too (see stackoverflow) .. :)
Great! Merged in 40f7542d1e3a8a3c490f3dcc2a08af45c273e245
This fixes #62: the notification bar is hindered from being closed by the verification dialog. However, while the XUL documentation states this can be done by throwing an error in the
eventCallback
function ofappendNotification
, this did not work for me. I instead put thethrow
into the callback function of the button.I also opened a post on stackoverflow on this issue, since I don't see why the method described in the documentation should not work.