search

arlolra / ctypes-otr

js-ctypes wrapper for libotr
Mozilla Public License 2.0
29 stars 7 forks source link

Add fingerprint manually after new contact was added #75

Closed vqhuy closed 8 years ago

vqhuy commented 8 years ago

Attempts to close #66

arlolra commented 8 years ago

Thanks! Just some initial comments so far; I haven't tested it yet. Will do so ASAP.

arlolra commented 8 years ago

Looks good in general.

When you finish inputting the fingerprint, there's a flash of the contact adding window that's undesirable.

This doesn't really help when a contact has already been added though, but probably still worth getting in anyways.

vqhuy commented 8 years ago

@arlolra :

This doesn't really help when a contact has already been added though, but probably still worth getting in anyways.

Did you mean we should prevent that window from flashing?

arlolra commented 8 years ago

No, I meant that if I add a contact and don't know their fingerprint at the time, but later learn it, I still can't enter it. Or, if I'm informed of a fingerprint change for one of my current contacts.

vqhuy commented 8 years ago

No, I meant that if I add a contact and don't know their fingerprint at the time, but later learn it, I still can't enter it. Or, if I'm informed of a fingerprint change for one of my current contacts.

Ah, I got it.

When you finish inputting the fingerprint, there's a flash of the contact adding window that's undesirable.

I changed the way how the dialog is opened (using openWindow instead of openDialog).

arlolra commented 8 years ago

Looking better, thanks Vu!

arlolra commented 8 years ago

Ok great, I merged this in 235a247b6.

One thing that's missing though, is a ui.rmBuddyContextMenu() to pair with ui.addBuddyContextMenu(), but not such a big deal.

Thanks again Huy!

arlolra commented 8 years ago

One thing that's missing though, is a ui.rmBuddyContextMenu() to pair with ui.addBuddyContextMenu(), but not such a big deal.

Sorry, that isn't true. You're pushing them in the hacky _addedNodes array, which will clean them up. My bad.

arlolra commented 8 years ago

See #76, which needs a followup.