Closed vqhuy closed 8 years ago
Thanks! Just some initial comments so far; I haven't tested it yet. Will do so ASAP.
Looks good in general.
When you finish inputting the fingerprint, there's a flash of the contact adding window that's undesirable.
This doesn't really help when a contact has already been added though, but probably still worth getting in anyways.
@arlolra :
This doesn't really help when a contact has already been added though, but probably still worth getting in anyways.
Did you mean we should prevent that window from flashing?
No, I meant that if I add a contact and don't know their fingerprint at the time, but later learn it, I still can't enter it. Or, if I'm informed of a fingerprint change for one of my current contacts.
No, I meant that if I add a contact and don't know their fingerprint at the time, but later learn it, I still can't enter it. Or, if I'm informed of a fingerprint change for one of my current contacts.
Ah, I got it.
When you finish inputting the fingerprint, there's a flash of the contact adding window that's undesirable.
I changed the way how the dialog is opened (using openWindow
instead of openDialog
).
Looking better, thanks Vu!
Ok great, I merged this in 235a247b6.
One thing that's missing though, is a ui.rmBuddyContextMenu()
to pair with ui.addBuddyContextMenu()
, but not such a big deal.
Thanks again Huy!
One thing that's missing though, is a ui.rmBuddyContextMenu() to pair with ui.addBuddyContextMenu(), but not such a big deal.
Sorry, that isn't true. You're pushing them in the hacky _addedNodes
array, which will clean them up. My bad.
See #76, which needs a followup.
Attempts to close #66