search

arlolra / ctypes-otr

js-ctypes wrapper for libotr
Mozilla Public License 2.0
29 stars 7 forks source link

Improve fingerprint usability when adding an account #76

Open arlolra opened 8 years ago

arlolra commented 8 years ago

Since #75, when adding an account (rather than a contact), I'm asked if I have a fingerprint for each contact associated with that account. For an account with lots of contacts, it can get tedious skipping them all.

We should probably avoid triggering the manual fingerprint window when adding an account.

/cc @c633

vqhuy commented 8 years ago

How does it trigger the fingerprint window when adding an account? I tried with my twitter account but after adding my account, nothing showed up.

arlolra commented 8 years ago

Yeah, the Twitter implementation is kind of odd in that it is modelled as a multi-user chat, similar to an IRC chatroom, with you and those you're following. Following someone there doesn't equate to adding them as a contact, but more of a join to the room.

This can best be tested with an XMPP account, that already has some contacts stored in the roster on the server.

clokep commented 8 years ago

"doesn't equate to adding them as a contact" is a bug that we've wanted fixed for a long time. It should be trivial to implement, but doesn't make much sense until direct messages are supported.

arlolra commented 8 years ago

@clokep Thanks for the reminder. I need to get on rebasing https://bugzilla.mozilla.org/show_bug.cgi?id=955642

vqhuy commented 8 years ago

We should probably avoid triggering the manual fingerprint window when adding an account.

Agree. I will create a PR for this issue in the next few days.

vqhuy commented 8 years ago

@arlolra: Did you have any solutions for this issue?

arlolra commented 8 years ago

I haven't looked into it yet, but thanks for reminding me. We should get this fixed before the next release.