Error in prefs (in tor message)

arlolra / ctypes-otr

js-ctypes wrapper for libotr

Mozilla Public License 2.0

29 stars 7 forks source link

Error in prefs (in tor message) #91

Closed beliashou closed 7 years ago

beliashou commented 7 years ago

Thank you for your product.

When I go to prefs of ctypes-otr in my tor messenger, I see:

XML Parsing Error: undefined entity
Location: chrome://otr/content/prefs.xul
Line Number 6, Column 1:<prefwindow id="otr-prefwindow"
^

When I start my chat, I see messages and buttons not russian or english, but like this: "المحادثة الحالية ليست خاصة."

Linux xubuntu 16.04, Tor messenger 0.2.0b2 (beta)

vqhuy commented 7 years ago

This is due to some missing translations of non-english languages. Here are steps to change the language to English:

Open Preferences > Advanced > Config Editor ...
Press the big button labeled "I'll be careful, I promise!".
In the search box, paste general.useragent.locale
In the search results, double-click general.useragent.locale and set its value to en-US
Restart Tor Messenger for the change to take effect.

Hope this help.

beliashou commented 7 years ago

@c633 , thank you for answer, but "general.useragent.locale" have already been set to "en-US".

vqhuy commented 7 years ago

@beliashou What is your OS's language? If it is not en, in the step 3 and 4 above, search for intl.locale.matchOS and change its value to false.

beliashou commented 7 years ago

Wow! Thank you! It solve the problem!

arlolra commented 7 years ago

@c633 @azadi We should patch this in Tor Messenger until trac 10945 is complete. Either,

set intl.locale.matchOS to false for all in the prefs patch
or, remove the incomplete translations from this extension for the time being.

vqhuy commented 7 years ago

~~I'd rather go with the later. Maybe we have a localization branch with current translations and remove the incomplete translations from master branch.~~ (see Arlo's suggestion below).

P.S: Sorry because of hastily closing this issue :(

arlolra commented 7 years ago

Another option is,

Import the translations before each release. Apparently these are being localized in transifex, https://www.transifex.com/otf/torproject/content/

arlolra commented 7 years ago

I'd rather go with the later.

Ok, let's do that. We should,

[x] Remove the current outdated non-en translations (maybe to another branch)
[ ] Write an import from transifex script (can borrow from TorBirdy)
[ ] Update the release process to include running the script

P.S: Sorry because of hastily closing this issue :(

Not a problem. Thanks for quickly identifying the issue and helping the user.

azadi commented 7 years ago

For now (which means for the upcoming release), I am fine with setting the pref to false unless you strongly disagree :)

arlolra commented 7 years ago

I am fine with setting the pref to false unless you strongly disagree

I think @c633 is saying the user experience is better when the translation is done in best effort.

arlolra commented 7 years ago

This was also reported on trac, https://trac.torproject.org/projects/tor/ticket/20231

Just noting the cross reference.