arlolra / otr

Off-the-Record Messaging Protocol implemented in JavaScript
https://arlolra.github.io/otr/
Mozilla Public License 2.0
458 stars 61 forks source link

Attach meta data to message #50

Closed sualko closed 10 years ago

sualko commented 10 years ago

According to #49

arlolra commented 10 years ago

This is looking alright. Could you squash the commits and remove any changes to the build directory. I guess you're ok with fragmented messages always returning the same meta data.

Also, you seem to be missing the path where messaged get stored for later delivery. I think that needs mending.

arlolra commented 10 years ago

Adding a test would be nice.

sualko commented 10 years ago

(I've always wanted to use this task list :-))

sualko commented 10 years ago

How is the way to run your unit tests? Maybe you can give me short explanation.

arlolra commented 10 years ago

make test

The test harness is mocha, which should be available when you npm install. The libotr test will fail unless you cd test; make as well. There's also Travis CI integration so if you enable that on your fork it'll lint the code and run the tests.

arlolra commented 10 years ago

A final thing to add to your list: please update the documentation.

Thanks for all the good work.

sualko commented 10 years ago

Now I hope everything is satisfying. I also added my owncloud and sogo app to the "in the wild" section.

arlolra commented 10 years ago

Merged manually (needed a rebase).

Thanks @sualko!