Closed sualko closed 10 years ago
This is looking alright. Could you squash the commits and remove any changes to the build directory. I guess you're ok with fragmented messages always returning the same meta data.
Also, you seem to be missing the path where messaged get stored for later delivery. I think that needs mending.
Adding a test would be nice.
(I've always wanted to use this task list :-))
How is the way to run your unit tests? Maybe you can give me short explanation.
make test
The test harness is mocha, which should be available when you npm install
. The libotr test will fail unless you cd test; make
as well. There's also Travis CI integration so if you enable that on your fork it'll lint the code and run the tests.
A final thing to add to your list: please update the documentation.
Thanks for all the good work.
Now I hope everything is satisfying. I also added my owncloud and sogo app to the "in the wild" section.
Merged manually (needed a rebase).
Thanks @sualko!
According to #49