Closed eric-seppanen closed 1 year ago
This looks great as well. No comments really, I think the ext file is in an ok place and the formatting is expected.
Merging #350 (3fe9627) into master (dbcff41) will decrease coverage by
0.16%
. The diff coverage is1.72%
.
@@ Coverage Diff @@
## master #350 +/- ##
=========================================
- Coverage 6.50% 6.35% -0.16%
=========================================
Files 131 136 +5
Lines 20243 20774 +531
=========================================
+ Hits 1317 1320 +3
- Misses 18926 19454 +528
Impacted Files | Coverage Δ | |
---|---|---|
src/client/base/async_std.rs | 89.42% <0.00%> (ø) |
|
src/error.rs | 14.28% <ø> (ø) |
|
src/ids.rs | 56.33% <ø> (ø) |
|
src/lib.rs | 100.00% <ø> (ø) |
|
src/resources/checkout_session_ext.rs | 0.00% <0.00%> (ø) |
|
src/resources/credit_note_ext.rs | 0.00% <0.00%> (ø) |
|
src/resources/customer_balance_transaction_ext.rs | 0.00% <0.00%> (ø) |
|
src/resources/generated/account.rs | 4.04% <0.00%> (ø) |
|
src/resources/generated/balance.rs | 0.00% <ø> (ø) |
|
src/resources/generated/billing_portal_session.rs | 0.00% <0.00%> (ø) |
|
... and 85 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Summary
Adds support for
CreditNote
andCustomerBalanceTransaction
objects, which are different ways of applying credit to a customer account.I wasn't sure whether
CustomerBalanceTransaction
actions (create, list, etc.) should be methods ofCustomer
or ofCustomerBalanceTransaction
; since they have the customer id in the API path, I chose to make them part ofCustomer
but left them in a separate modulecustomer_balance_transaction_ext.rs
. It would be easy to change either of those decisions if you disagree.Note: this adopts 3 previously-unused generated modules, which means that
cargo make fmt
saw them for the first time. I'm not sure if committing those formatting changes is the right step, but I included that as a separate commit.Checklist
cargo make fmt