arlyon / async-stripe

Async (and blocking!) Rust bindings for the Stripe API
https://payments.rs
Apache License 2.0
464 stars 130 forks source link

fix: Add sis_ id prefix for usage record summaries #371

Closed sam-butcher closed 1 year ago

sam-butcher commented 1 year ago

Summary

Adds the sis_ id as an option for UsageRecordSummaryIds, as seen in the Stripe API docs - see the Response example at https://stripe.com/docs/api/usage_records/subscription_item_summary_list

Checklist

sam-butcher commented 1 year ago

@arlyon Would it be possible for you to take a look at this?

arlyon commented 1 year ago

Oops, thanks for the ping, my notifications have been a mess recently! I will run CI now, thanks for taking the time.

arlyon commented 1 year ago

I have pushed a change to fix the CI msrv pin issue, please rebase when you get the chance and ping me when its done :)

sam-butcher commented 1 year ago

@arlyon Done!

sam-butcher commented 1 year ago

@arlyon sorry for pinging again, can I get a bump on CI for this?

codecov[bot] commented 1 year ago

Codecov Report

Merging #371 (1042493) into master (9bcd6a8) will decrease coverage by 0.42%. The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #371      +/-   ##
=========================================
- Coverage    6.24%   5.83%   -0.42%     
=========================================
  Files         141     140       -1     
  Lines       21133   21029     -104     
=========================================
- Hits         1319    1226      -93     
+ Misses      19814   19803      -11     
Impacted Files Coverage Δ
src/ids.rs 56.33% <ø> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

arlyon commented 1 year ago

All merged! I'll baby-sit the release as well and ping you when it's done.